-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure SDK and remove deprecated autorest dependency #3040
Update Azure SDK and remove deprecated autorest dependency #3040
Conversation
Welcome @phillebaba! |
20635f1
to
8032591
Compare
f7b0f97
to
ef47d7f
Compare
026e5fe
to
5fd7eb1
Compare
5fd7eb1
to
4bed72f
Compare
}{ | ||
"AzureChinaCloud": {"AzureChinaCloud", nil}, | ||
"AzureGermanCloud": {"AzureGermanCloud", nil}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
German Cloud does not exist anymore so it has been removed from the configuration.
Azure/azure-sdk-for-go#19112
4bed72f
to
cdec7bc
Compare
@phillebaba Do you think you can rebase this PR ? The CI is now fixed. |
9395e31
to
933e4cc
Compare
1c8208f
to
5ca126f
Compare
5ca126f
to
70eda8b
Compare
@phillebaba I left one small suggestion on error handling, otherwise it LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I note that support for AAAA records is noticeably absent. Not blocking.
Co-authored-by: John Gardiner Myers <[email protected]>
Co-authored-by: John Gardiner Myers <[email protected]>
Co-authored-by: Michel Loiseleur <[email protected]>
/lgtm |
Excited to see there is movement on this MR, can't wait for this feature to be available. Do we know when a release might occur with this feature included? |
@mloiseleur @johngmyers can any of you put the approved tag ? 😅 |
Neither of us is an approver |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phillebaba, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
This PR updates the Azure SDK to the latest stable version and replaces the use of the deprecated autorest with azidentity.
Fixes #3211
Checklist