Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail in current master (golang 1.8 in docker build) #394

Closed
hjacobs opened this issue Nov 20, 2017 · 1 comment
Closed

Tests fail in current master (golang 1.8 in docker build) #394

hjacobs opened this issue Nov 20, 2017 · 1 comment
Assignees
@hjacobs
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@hjacobs
Copy link
Contributor

hjacobs commented Nov 20, 2017

docker build -t test . on CI fails:

9:09:29 PM --- PASS: TestTXTRegistry/TestApplyChanges/No_prefix (0.00s)
9:09:29 PM PASS
9:09:29 PM ok github.com/kubernetes-incubator/external-dns/registry 1.031s
9:09:33 PM # github.com/kubernetes-incubator/external-dns/source
9:09:33 PM source/service_test.go:1017: not enough arguments in call to NewServiceSource
9:09:33 PM have (*"github.com/kubernetes-incubator/external-dns/vendor/k8s.io/client-go/kubernetes/fake".Clientset, string, string, string, bool)
9:09:33 PM want (kubernetes.Interface, string, string, string, string, bool)
9:09:33 PM FAIL github.com/kubernetes-incubator/external-dns/source [build failed]
9:09:33 PM make: *** [test] Error 2
9:09:33 PM Makefile:35: recipe for target 'test' failed
9:09:34 PM The command '/bin/sh -c make test' returned a non-zero code: 2
@hjacobs hjacobs added the kind/bug Categorizes issue or PR as related to a bug. label Nov 20, 2017
@hjacobs
Copy link
Contributor Author

hjacobs commented Nov 20, 2017

Seems to be caused by merging #324

@hjacobs hjacobs self-assigned this Nov 20, 2017
hjacobs added a commit that referenced this issue Nov 20, 2017
@hjacobs
#394 fix broken tests caused by conflicting PR merges
e32f095
@hjacobs hjacobs closed this as completed Nov 20, 2017
ffledgling pushed a commit to ffledgling/external-dns that referenced this issue Jan 18, 2018
@hjacobs
kubernetes-sigs#394 fix broken tests caused by conflicting PR merges
b22bd7d
lou-lan pushed a commit to lou-lan/external-dns that referenced this issue May 11, 2022
@corneliusweig @k8s-ci-robot
[docs] Improve annotated plugin manifest (kubernetes-sigs#394)
28fbf81 
* [docs] Improve annotated plugin manifest

- explicitly show that you need to install a LICENSE file
- mention size limitations in shortDescription

* [docs] remove leading slash in file names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjacobs hjacobs

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hjacobs