-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingress dns-controller should be opt-in, not opt-out #362
Comments
Agreed, at least could have an option to set default to be either opt-in or opt-out? |
@szuecs @ideahitme @mikkeloscar What do you think? |
A flag that would allow either default opt-in or default opt out makes sense to me. It would be annoying (and a breaking change) to configure every single ingress object for opt-in if you intend to have dns entries out of the box in your cluster/ingress setup. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Remove trueVerifier from main logic This verifier implementation is only used in tests, so it should be defined there. * Remove test for trueVerifier
Hi,
I am starting to happily use external-dns, but I think it should not automatically opt-in for ingresses while using the --ingresses option.
It's an annotation to opt-in for services, but an annotation to opt-out for ingresses.
The annotation for opt-out works well by the way, but it's a strange usage in a declarative configuration world.
Related issues:
#143
#107
The text was updated successfully, but these errors were encountered: