Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress dns-controller should be opt-in, not opt-out #362

Closed
arthur-c opened this issue Oct 17, 2017 · 7 comments
Closed

Ingress dns-controller should be opt-in, not opt-out #362

arthur-c opened this issue Oct 17, 2017 · 7 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@arthur-c
Copy link

Hi,

I am starting to happily use external-dns, but I think it should not automatically opt-in for ingresses while using the --ingresses option.

It's an annotation to opt-in for services, but an annotation to opt-out for ingresses.

The annotation for opt-out works well by the way, but it's a strange usage in a declarative configuration world.

Related issues:
#143
#107

@javefang
Copy link
Contributor

Agreed, at least could have an option to set default to be either opt-in or opt-out?

@linki
Copy link
Member

linki commented Nov 13, 2017

@szuecs @ideahitme @mikkeloscar What do you think?

@mikkeloscar
Copy link
Contributor

A flag that would allow either default opt-in or default opt out makes sense to me.

It would be annoying (and a breaking change) to configure every single ingress object for opt-in if you intend to have dns entries out of the box in your cluster/ingress setup.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 22, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lou-lan pushed a commit to lou-lan/external-dns that referenced this issue May 11, 2022
* Remove trueVerifier from main logic

This verifier implementation is only used in tests, so it should be defined there.

* Remove test for trueVerifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants