Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes CustomResourceDefinition Source #21

Closed
linki opened this issue Feb 17, 2017 · 9 comments
Closed

Add Kubernetes CustomResourceDefinition Source #21

linki opened this issue Feb 17, 2017 · 9 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. source
Milestone

Comments

@linki
Copy link
Member

linki commented Feb 17, 2017

Add a source that lists/watches for a specific CustomResourceDefinition objects.

We could make a CRD the central source for DNS entries. And then just create those objects as needed. This would allow other components to declare DNS entries as well.

@linki linki changed the title Add Kubernetes ThirdPartySource Source Add Kubernetes ThirdPartyResource Source Feb 17, 2017
@ideahitme
Copy link

what is the need for that?

@linki
Copy link
Member Author

linki commented Feb 20, 2017

Would just be an alternative way of defining DNS records from inside Kubernetes in a provider independent way.

@ideahitme
Copy link

I would postpone this till we get some simple version running :)

@linki linki added this to the post-v1.0 milestone Apr 3, 2017
@linki linki changed the title Add Kubernetes ThirdPartyResource Source Add Kubernetes CustomResourceDefinition Source Oct 4, 2017
@munnerz
Copy link
Member

munnerz commented Mar 1, 2018

We're interested in this, or similar, in cert-manager.

Right now we bake in support for various DNS providers into cert-manager itself in order to update TXT records in order to solve ACME challenges. If we could somehow define a TXT record without directly calling out to DNS provider APIs ourself, it'd be a great addition and simplify our codebase considerably.

Generally speaking, a 'DNS controller' that is not bound to services or ingress would also be very useful.

We have a simple model for managing a similar problem in cert-manager:

A user can define a Certificate resource (our own CRD), which allows for advanced customisation of certificates (e.g. explicit CN or special types of subject alt name). We also allow a user to add a simple annotation (kubernetes.io/tls-acme: "true") on ingress resources. We have a component that watches for Ingress resources with this label, and automatically creates and manages a corresponding Certificate resource in order to fulfil the Certificate. This solves the code duplication problem, and gives user a consistent way to debug validation problems.

This same model could be used to provide a migration/transition path from the current external-dns design to something powered by CRDs/custom resources.

More info on how we do this in cert-manager here: https://github.com/jetstack/cert-manager/tree/master/cmd/ingress-shim

@2rs2ts
Copy link

2rs2ts commented Mar 12, 2018

It would also be nice to be able to use kubectl get dns or something like that to look at the DNS records that external-dns created :)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 23, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 23, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lou-lan pushed a commit to lou-lan/external-dns that referenced this issue May 11, 2022
I'm not entirely sure if we need both GitTag and GitCommit. This is primarily
for tagging release binaries easily (where the git repo is supposed to exist).

Fixes kubernetes-sigs#20.

Signed-off-by: Ahmet Alp Balkan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. source
Projects
None yet
Development

No branches or pull requests

7 participants