Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for armv7 and arm64 docker images #1385

Closed
vchrisb opened this issue Jan 21, 2020 · 5 comments
Closed

support for armv7 and arm64 docker images #1385

vchrisb opened this issue Jan 21, 2020 · 5 comments
Labels
triage/duplicate Indicates an issue is a duplicate of other open issue.

Comments

@vchrisb
Copy link

vchrisb commented Jan 21, 2020

With external-dns becoming part of the official kubernetes ecosystem, it would be helpful to support armv7 and arm64 docker images.

Using docker buildx on Docker for Mac, external-dns can be build easily with only a small change in the Makefile or Dockerfile.
Golang does not support race checks for armv7 and does not work on Docker for Mac at all, because it apparently uses a smaller vma of 39 instead of 42.
So either it is necessary to remove the go test step in the Dockerfile or remove the -race in the Makefile for building multiaarch images.

Using Github Actions with https://github.com/crazy-max/ghaction-docker-buildx works great too, but also lacks a vma of 42.
So adding sed -i'.bak' -e s/-race//g Makefile to the build script works:
https://github.com/vchrisb/external-dns/blob/master/.github/workflows/main.yml

My Multiaarch Images can be found here: https://hub.docker.com/repository/docker/vchrisb/external-dns

My orginal is issue #1139 which closed.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2020
@Raffo
Copy link
Contributor

Raffo commented Apr 20, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2020
@sean-abbott
Copy link

I am using vchrisb's image and it works well, but it'd be nice to just have it coming straight from the source at release time.

@seanmalloy
Copy link
Member

/close
/triage duplicate

This is a duplicate of #1443.

@k8s-ci-robot k8s-ci-robot added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Aug 13, 2020
@k8s-ci-robot
Copy link
Contributor

@seanmalloy: Closing this issue.

In response to this:

/close
/triage duplicate

This is a duplicate of #1443.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

No branches or pull requests

6 participants