-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for armv7 and arm64 docker images #1385
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
I am using vchrisb's image and it works well, but it'd be nice to just have it coming straight from the source at release time. |
/close This is a duplicate of #1443. |
@seanmalloy: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
With
external-dns
becoming part of the official kubernetes ecosystem, it would be helpful to supportarmv7
andarm64
docker images.Using docker buildx on Docker for Mac,
external-dns
can be build easily with only a small change in the Makefile or Dockerfile.Golang does not support race checks for
armv7
and does not work on Docker for Mac at all, because it apparently uses a smaller vma of 39 instead of 42.So either it is necessary to remove the
go test
step in the Dockerfile or remove the-race
in the Makefile for building multiaarch images.Using Github Actions with https://github.com/crazy-max/ghaction-docker-buildx works great too, but also lacks a vma of 42.
So adding
sed -i'.bak' -e s/-race//g Makefile
to the build script works:https://github.com/vchrisb/external-dns/blob/master/.github/workflows/main.yml
My Multiaarch Images can be found here: https://hub.docker.com/repository/docker/vchrisb/external-dns
My orginal is issue #1139 which closed.
The text was updated successfully, but these errors were encountered: