Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emeritus bentheelder #107

Merged
merged 1 commit into from
Feb 4, 2022
Merged

emeritus bentheelder #107

merged 1 commit into from
Feb 4, 2022

Conversation

BenTheElder
Copy link
Member

I haven't had time to be suitably active in this repo like I should be as a reviewer / approver.

@BenTheElder
emeritus bentheelder
c3e6556 
I haven't had time to be suitably active in this repo like I should be as a reviewer / approver.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 3, 2022
@k8s-ci-robot k8s-ci-robot requested a review from spiffxp February 3, 2022 22:32
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2022
@BenTheElder BenTheElder mentioned this pull request Feb 3, 2022
Merged
@BenTheElder
Copy link
Member Author

/retest

@BenTheElder BenTheElder requested review from vladimirvivien and removed request for spiffxp February 4, 2022 00:10
cpanato
cpanato approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ben! <3

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b8b1432 into main Feb 4, 2022
@BenTheElder BenTheElder deleted the BenTheElder-patch-1 branch February 4, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@ShwethaKumbla ShwethaKumbla Awaiting requested review from ShwethaKumbla

@vladimirvivien vladimirvivien Awaiting requested review from vladimirvivien

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @cpanato