e2e: fail on errors

[bart0sh]

It would be more user friendly to fail on errors when running e2e tests.

Here is an example of how does make e2e behaves before and after this fix:

• Before

$ make test-e2e
test/e2e/e2e.sh
dra-example-driver-cluster
NAME                                       STATUS   ROLES           AGE    VERSION
dra-example-driver-cluster-control-plane   Ready    control-plane   4d4h   v1.31.0
dra-example-driver-cluster-worker          Ready    <none>          4d4h   v1.31.0
node/dra-example-driver-cluster-worker condition met
Error from server (AlreadyExists): error when creating "demo/gpu-test1.yaml": namespaces "gpu-test1" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test1.yaml": resourceclaimtemplates.resource.k8s.io "single-gpu" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test1.yaml": pods "pod0" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test1.yaml": pods "pod1" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test2.yaml": namespaces "gpu-test2" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test2.yaml": resourceclaimtemplates.resource.k8s.io "multiple-gpus" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test2.yaml": pods "pod0" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test3.yaml": namespaces "gpu-test3" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test3.yaml": resourceclaimtemplates.resource.k8s.io "single-gpu" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test3.yaml": pods "pod0" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test4.yaml": namespaces "gpu-test4" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test4.yaml": resourceclaims.resource.k8s.io "single-gpu" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test4.yaml": pods "pod0" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test4.yaml": pods "pod1" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test5.yaml": namespaces "gpu-test5" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test5.yaml": resourceclaimtemplates.resource.k8s.io "multiple-gpus" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test5.yaml": pods "pod0" already exists
pod/pod0 condition met
pod/pod1 condition met
pod/pod0 condition met
pod/pod0 condition met
pod/pod0 condition met
pod/pod1 condition met
pod/pod0 condition met
test ran successfully

• After

$ make test-e2e
test/e2e/e2e.sh
dra-example-driver-cluster
NAME                                       STATUS   ROLES           AGE    VERSION
dra-example-driver-cluster-control-plane   Ready    control-plane   4d4h   v1.31.0
dra-example-driver-cluster-worker          Ready    <none>          4d4h   v1.31.0
node/dra-example-driver-cluster-worker condition met
Error from server (AlreadyExists): error when creating "demo/gpu-test1.yaml": namespaces "gpu-test1" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test1.yaml": resourceclaimtemplates.resource.k8s.io "single-gpu" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test1.yaml": pods "pod0" already exists
Error from server (AlreadyExists): error when creating "demo/gpu-test1.yaml": pods "pod1" already exists
make: *** [Makefile:120: test-e2e] Error 1

[bart0sh]

/cc @klueska

[klueska]

I'm fine either way. I'll let @kannon92 / @byako decide (since Alexey had a similar comment on the original PR adding the e2e tests).

[byako]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, byako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bart0sh,byako]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment