Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demo specs to replace sleep command with one that catches SIGTERM #62

Closed
wants to merge 1 commit into from

Conversation

klueska
Copy link
Contributor

@klueska klueska commented Sep 16, 2024

This allows all of the demo pods to terminate immediately, without needing to wait for the grace-period of 30s before they receive a SIGKILL.

This allows all of the demo pods to terminate immediately, without
needing to wait for the grace-period of 30s before they receive a
SIGKILL.

Signed-off-by: Kevin Klues <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2024
@klueska
Copy link
Contributor Author

klueska commented Sep 16, 2024

/cc @pohly @bart0sh @aojea

@k8s-ci-robot k8s-ci-robot requested a review from aojea September 16, 2024 22:12
@klueska
Copy link
Contributor Author

klueska commented Sep 17, 2024

Looks like @bart0sh beat me to it with #61

@klueska klueska closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants