Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDI specification to v0.8.0 #52

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Aug 9, 2024

These changes update the imported CDI specification to v0.8.0. This includes the migration to the tags.cncf.io repository.

elezar added 2 commits August 9, 2024 22:26
This includes a migration to tags.cncf.io.

Signed-off-by: Evan Lezar <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2024
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and byako August 9, 2024 20:28
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2024
@elezar elezar mentioned this pull request Aug 9, 2024
@elezar
Copy link
Contributor Author

elezar commented Aug 9, 2024

/cc @klueska

@k8s-ci-robot k8s-ci-robot requested a review from klueska August 9, 2024 20:30
@klueska
Copy link
Contributor

klueska commented Aug 10, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elezar, klueska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2b2fddc into kubernetes-sigs:main Aug 10, 2024
5 checks passed
@elezar elezar deleted the update-cdi branch August 10, 2024 09:41
@klueska
Copy link
Contributor

klueska commented Aug 12, 2024

I should have probably tested this before merging it -- after this change CDI injection is not working...

The underlying issue was that the version of containerd included in my node image was too old. We removed support for injecting CDI devices via annotations in 1.31 and the version of containerd my node image (v1.7.1) had was too old to work with CDI devices passed via CRI. After upgrading kind to a newer version, this resolved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants