Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for structured parameters #47
Add support for structured parameters #47
Changes from all commits
a064d04
6b1df1b
f35a0cd
c82ba30
41ca66b
f46eea8
0a0a8bd
62a4696
8c7f2a7
49c8d0a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to separate random suffix from the name, e.g.
dra-example-driver-cluster-worker-gpu.resource.example.comxktph
->dra-example-driver-cluster-worker-gpu.resource.example.com.xktph
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a question for @pohly -- this comes from his library for generating the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
GenerateName: dra-example-driver-cluster-worker-gpu.resource.example.com-
already has a trailing-
. But as that prefix is long, Kubernetes truncates it and drops the trailing-
.One way to avoid that would be to truncate the
<node>-<driver>-
string in advance if it is too long, for example by cutting out some characters in the middle of each sub-component. Would that be better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear: that library produces
generateName
, not thename
- that is the name generated by Kubernetes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Showing that parameters got converted when using structured parameters would be useful here. OTOH, it's not very impressive right now. So perhaps not (yet)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's not very interesting yet ... I will definitely add this once I open a PR introduce selection via a vendor-specific CRD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will wait to do this as part of the 1.31 update
This file was deleted.
This file was deleted.