Project migrated under kubernetes-sigs, change import path prefix to sigs.k8s.io/descheduler #182
Conversation
…sigs.k8s.io/descheduler
k8s-ci-robot
added
cncf-cla: yes
|
@ingvagabund thanks. Is it ready to be merged? /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aveshagarwal, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@aveshagarwal debugging failing tests in travis |
Thanks. Please let me know once it is ready and i will merge it. |
ingvagabund
force-pushed
the
rename-import-path-prefix
branch
2 times, most recently
from
1bed808 to
94c7b74
Compare
Looks like Travis does not honor the new repository location.
ingvagabund
force-pushed
the
rename-import-path-prefix
branch
from
94c7b74 to
9d6b609
Compare
|
@aveshagarwal ready |
| @@ -18,6 +18,8 @@ before_script: | |||
| - kind load docker-image kubernetes/pause | |||
| - cp "$(kind get kubeconfig-path --name="kind")" /tmp/admin.conf | |||
| script: | |||
| - mkdir -p ~/gopath/src/sigs.k8s.io/ | |||
| - mv ~/gopath/src/github.com/kubernetes-sigs/descheduler ~/gopath/src/sigs.k8s.io/. | |||
There was a problem hiding this comment.
is the dot at the end intentional? just asking does not matter much.
There was a problem hiding this comment.
Just my convention. I can remove it if needed.
There was a problem hiding this comment.
i am fine, have not seen that frequently (for current dir at the end of the path) so asking.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
aveshagarwal
changed the title
was not changed in kubernetes-sigs#182
…-path-prefix Project migrated under kubernetes-sigs, change import path prefix to sigs.k8s.io/descheduler
was not changed in kubernetes-sigs#182
See also kubernetes/org#1176