Fix cri-dockerd CI runs #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
dcantah
force-pushed
the
fix-dockershim-ci
branch
from
396f7d9 to
eeb35fe
Compare
dcantah
force-pushed
the
fix-dockershim-ci
branch
from
eeb35fe to
72040da
Compare
k8s-ci-robot
added
size/S
dcantah
force-pushed
the
fix-dockershim-ci
branch
3 times, most recently
from
55d6c2f to
0ee4b31
Compare
github.com/Mirantis/cri-dockerd has changed a couple things that were affecting the CI. The code has moved to a src/ subdirectory so running 'go install .' at the root of the repo fails on finding anything. The default addresses have also changed from /var/run/dockershim.sock (and //./pipe/dockershim) to /var/run/cri-dockerd.sock. A couple of flags also don't seem to exist anymore, namely --logtostderr and --v. All in all this change cds to the src subdirectory before trying to build/install anything, makes cri-dockerd launch with the old dockershim address, and gets rid of the now nonexistent flags. Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
fix-dockershim-ci
branch
from
0ee4b31 to
f2091fc
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Ok this looks like it's ready after testing this locally @feiskyer |
|
We could go either way in this PR also for the address. Pass the new default address to critest under the -runtime-endpoint and -image-endpoint flags or do what we have currently and launch cri-dockerd with the old default address. Or change these https://github.com/kubernetes-sigs/cri-tools/blob/master/pkg/framework/test_context.go#L74-L78 but I'm not sure if this makes sense at the moment. |
feiskyer
reviewed
Dec 31, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcantah, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
github.com/Mirantis/cri-dockerd has changed a couple things that were affecting the CI. The code has moved to a src/ subdirectory so running 'go install .' at the root of the repo fails on finding anything. The default addresses have also changed from /var/run/dockershim.sock (and //./pipe/dockershim) to /var/run/cri-dockerd.sock. A couple of flags also don't seem to exist anymore, namely --logtostderr and --v. All in all this change cds to the src subdirectory before trying to build/install anything, makes cri-dockerd launch with the old dockershim address, and gets rid of the now nonexistent flags.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?