Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor Kubernetes 1.16.0-rc.2 #532

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

saschagrunert
Copy link
Member

Vendoring the latest RC to see how the CI behaves and adding the new Status.Network.AdditionalIps fields for pods.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 11, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 11, 2019
@Random-Liu
Copy link
Contributor

@saschagrunert Is this WIP?

And what command did you run to update the go mod? Just for my education.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert saschagrunert changed the title WIP: Vendor Kubernetes 1.16.0-rc.1 Vendor Kubernetes 1.16.0-rc.2 Sep 17, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2019
@saschagrunert
Copy link
Member Author

@saschagrunert Is this WIP?

And what command did you run to update the go mod? Just for my education.

I updated it to RC2 and removed the WIP as discussed.

For the general update, I manually edited go.mod to contain the same commit (the release candidate) in the replace section at the bottom. Then running ./hack/verify-go-modules.sh should vendor in the changes. :)

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [feiskyer,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8044930 into kubernetes-sigs:master Sep 17, 2019
@saschagrunert saschagrunert deleted the kubernetes-1.16 branch September 17, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants