Add first crictl e2e test framework and suite #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
saschagrunert
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
saschagrunert
force-pushed
the
e2e-tests
branch
12 times, most recently
from
02062fa to
99e1f1b
Compare
saschagrunert
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Now runs seamlessly in travis :) |
This adds a new Makefile target `test-e2e`, which uses the existing ginkgo framework to run end-to-end tests for `crictl`. The test framework and suite setups CRI-O in a tmp sandbox, whereas every test can specify if a runtime is needed or not. This way it is possible to create a new isolated environment where `crictl` can operate on. Please be aware that external dependencies like `runc` and the CNI plugins have to be existend on the system to acually work. The tests have to be executed as root for now. An example test suite for the `help` as well as the `info` command has been added as well. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
e2e-tests
branch
from
99e1f1b to
7fa2522
Compare
feiskyer
reviewed
Sep 10, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new Makefile target
test-e2e, which uses the existingginkgo framework to run end-to-end tests for
crictl.The test framework and suite setups CRI-O in a tmp sandbox, whereas
every test can specify if a runtime is needed or not. This way it is
possible to create a new isolated environment where
crictlcan operateon. Please be aware that external dependencies like
runcand the CNIplugins have to be existend on the system to acually work. The tests
have to be executed as root for now.
An example test suite for the
helpas well as theinfocommand hasbeen added as well.
Relates to: #364