Make runtime and image client non-global variables #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
saschagrunert
changed the title
k8s-ci-robot
added
the
size/L
This commits removed the three global variables: ``` var runtimeClient pb.RuntimeServiceClient var imageClient pb.ImageServiceClient var conn *grpc.ClientConn ``` and scopes them to their actual used functions. This avoids usage of the variables if they are uninitialized and provides a more clear control flow. All related functions have been adapted to work with the new functions. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
remove-public-vars
branch
from
e4ff4c3 to
f55f3fd
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits removed the three global variables:
and scopes them to their actual used functions. This avoids usage of the
variables if they are uninitialized and provides a more clear control
flow.
All related functions have been adapted to work with the new functions.