Move from gometalinter to golangci-lint #494
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
saschagrunert
force-pushed
the
golangci-lint
branch
8 times, most recently
from
4036f77 to
1a974b2
Compare
|
CI is still failing. @saschagrunert could you check why the CI is failing? |
Yes, I'm just wondering if the issues are the same like on the master branch. I'll do some investigation now. |
saschagrunert
force-pushed
the
golangci-lint
branch
3 times, most recently
from
9250c72 to
c846886
Compare
gometalinter has been deprecated so we move to golangci-lint as successor project. The installation of the tool is not necessary any more, since we vendor the dependency directly into the repository. This allows more reproducible lint results. All linters which currently pass have been enabled. The gofmt and govet lint scripts have been removed because they are now included in golangci-lint as well. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
golangci-lint
branch
from
c846886 to
5ec5bfe
Compare
|
The windows issue is fixed, but the ppc critest seems flaky. I'm checking further test cases... |
|
It works now, if the flakes coming again I think we have to re-evaluate the critest related integration tests... |
Looks good to me. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
gometalinter has been deprecated so we can move to golangci-lint as
successor project. The installation of the tool is not necessary any
more, since we vendor the dependency directly into the repository. This
allows more reproducible lint results. All linters which currently pass
have been enabled. The gofmt and govet lint scripts have been removed
because they are now included in golangci-lint as well.