Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container 'run' command #492

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

saschagrunert
Copy link
Member

The new run command can be used as convienence wrapper to the workflow
of:

  1. Creating a pod
  2. Creating a container within this pod
  3. Starting the container within the pod

The new `run` command can be used as convienence wrapper to the workflow
of:

1. Creating a pod
2. Creating a container within this pod
3. Starting the container within the pod

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2019
@Random-Liu
Copy link
Contributor

I've wanted this long time ago! Thanks!

@Random-Liu Random-Liu self-assigned this Aug 1, 2019
@Random-Liu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 63fdd9c into kubernetes-sigs:master Aug 1, 2019
@saschagrunert saschagrunert deleted the run-container branch August 1, 2019 17:33
@feiskyer
Copy link
Member

feiskyer commented Aug 2, 2019

cool, thanks for adding this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants