-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search program directory for config as fallback #463
Search program directory for config as fallback #463
Conversation
Causes crictl to search its own directory for crictl.yaml if the user does not specify a config path, and the default global path does not exist. Signed-off-by: Kevin Parsons <[email protected]>
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@kevpar - FYI |
@feiskyer - PTAL when you get a chance. |
lgtm. @kevpar Could you sign the CLA? |
the commit is from him, so I think it's still required to pass the CLA check. |
/check-cla |
I have signed the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, jterry75 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! |
Causes crictl to search its own directory for crictl.yaml if the user
does not specify a config path, and the default global path does not
exist.
Signed-off-by: Kevin Parsons [email protected]
Signed-off-by: Justin Terry (VM) [email protected]