Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add simple completion support for zsh #442

Merged
merged 2 commits into from
Mar 15, 2019
Merged

add simple completion support for zsh #442

merged 2 commits into from
Mar 15, 2019

Conversation

cpointner
Copy link
Contributor

fixes #435.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and runcom March 11, 2019 16:35
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2019
feiskyer
feiskyer reviewed Mar 13, 2019
View reviewed changes
cmd/crictl/completion.go Outdated Show resolved Hide resolved
feiskyer
feiskyer reviewed Mar 13, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nits. The CI is failing because of docker installation, I'm fixing the docker issues today

@feiskyer feiskyer added this to the v1.14 milestone Mar 14, 2019
@feiskyer
Copy link
Member

close-reopen for re-trigger Travis CI

@feiskyer feiskyer closed this Mar 15, 2019
@feiskyer feiskyer reopened this Mar 15, 2019
@feiskyer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpointner, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 521d756 into kubernetes-sigs:master Mar 15, 2019
@cpointner cpointner deleted the zsh-completion branch March 26, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@runcom runcom Awaiting requested review from runcom

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

crictl completion for zsh
3 participants
@cpointner @feiskyer @k8s-ci-robot