Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crictl: add option to filter by container name in ps #404

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

runcom
Copy link
Contributor

@runcom runcom commented Nov 7, 2018

This way users can do one liner like this one to grab logs out of a particular container:

crictl logs $(crictl ps --pod $(crictl pods --name kube-dns -q) --name kubedns -q)

Signed-off-by: Antonio Murdaca [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2018
@Random-Liu
Copy link
Contributor

cmd/crictl/sandbox_test.go:63:9:warning: undefined: podMatchesRegex (vetshadow)
cmd/crictl/sandbox_test.go:63:9:error: undefined: podMatchesRegex (vet)

@runcom
Copy link
Contributor Author

runcom commented Nov 8, 2018

Oh gosh, fixing that

@runcom
Copy link
Contributor Author

runcom commented Nov 8, 2018

@Random-Liu fixed

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit c051948 into kubernetes-sigs:master Nov 8, 2018
@runcom runcom deleted the filter-ctrs-name branch November 8, 2018 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants