Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Windows default runtime endpoints to npipe #398

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Switch Windows default runtime endpoints to npipe #398

merged 2 commits into from
Nov 8, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Oct 31, 2018 •
edited
Loading

Refer kubernetes/kubernetes#69516.

This PR switches Windows default runtime endpoints to npipe and enables basic runtime info tests for Windows.

Kubernetes version has also been updated to master in the first commit.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2018
@feiskyer feiskyer added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
@feiskyer feiskyer force-pushed the npipe branch 4 times, most recently from 37c3115 to 916523d Compare November 2, 2018 09:05
@feiskyer feiskyer added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2018
@feiskyer feiskyer removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Nov 6, 2018

cc @jterry75 @PatrickLang

jterry75
jterry75 approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feiskyer feiskyer added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit c080f38 into kubernetes-sigs:master Nov 8, 2018
@feiskyer feiskyer deleted the npipe branch November 8, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jterry75 jterry75 jterry75 approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feiskyer @k8s-ci-robot @jterry75