-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error way of parsing URL for cmd exec and attach #392
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Subcmd exec and attach parse URL according to prefix “http”, Parse by prefix http, which may generate invalid http address We should parse URL just like streaming.go |
Signed |
The Travis CI failed due to go version in build machine is lower than go1.11.1 |
Yep, k/k requires go 1.11.1 now. Let me update Go version first. |
fb80177
to
db35d02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Re-trigger travis testing... |
gofmt check failed. @tanyifeng Could you fix gofmt issues? |
db35d02
to
f428b77
Compare
Done |
Signed-off-by: t00416110 <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, tanyifeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Parsing URL with url.schema other than prefix of URL.
Signed-off-by: t00416110 [email protected]