Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor latest github.com/urfave/cli #372

Merged
merged 1 commit into from
Aug 30, 2018
Merged

vendor latest github.com/urfave/cli #372

merged 1 commit into from
Aug 30, 2018

Conversation

vrothberg
Copy link
Contributor

The update includes various fixes regarding arg parsing, short-opts in
particular.

Fixes: #335
Signed-off-by: Valentin Rothberg [email protected]

The update includes various fixes regarding arg parsing, short-opts in
particular.

Fixes: #335
Signed-off-by: Valentin Rothberg <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2018
@feiskyer
Copy link
Member

@vrothberg thanks for fixing this

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2018
@feiskyer feiskyer merged commit 2ad880c into kubernetes-sigs:master Aug 30, 2018
@vrothberg vrothberg deleted the cli-vendor branch August 30, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crictl-exec: arg-parsing bug
3 participants