Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ldflags in hack/release.sh #367

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Aug 9, 2018

Set ldflags in hack/release.sh so 'crictl -v' and 'critest -version'
show the correct version.

/cc @Random-Liu @feiskyer

Signed-off-by: Andy Goldstein [email protected]

Set ldflags in hack/release.sh so 'crictl -v' and 'critest -version'
show the correct version.

Signed-off-by: Andy Goldstein <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2018
@Random-Liu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2018
@Random-Liu Random-Liu merged commit d658483 into kubernetes-sigs:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants