Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup container and sandbox state. #316

Merged
merged 1 commit into from
May 27, 2018
Merged

Cleanup container and sandbox state. #316

merged 1 commit into from
May 27, 2018

Conversation

Random-Liu
Copy link
Contributor

@Random-Liu Random-Liu commented May 26, 2018 •
edited
Loading

This:

  1. Tolerant both upper/lower case for state filter.
  2. Change "stopped" to "exited". Container can exit itself, which is not "stopped".
  3. Remove CONTAINER_ and SANDBOX_ prefix from state. Especially "SANDBOX_" is confusing to user after we introduce "sandbox" concept in Kubernetes api.

Signed-off-by: Lantao Liu [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2018
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2018
feiskyer
feiskyer reviewed May 27, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feiskyer feiskyer merged commit eae53b2 into kubernetes-sigs:master May 27, 2018
@Random-Liu Random-Liu deleted the clean-up-state branch May 29, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Random-Liu @feiskyer @k8s-ci-robot