Make hostnet-nginx test images multi-arch #313
Merged
+65
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #287 Signed-off-by: Nitesh Konkar <[email protected]>
k8s-ci-robot
added
size/M
|
/cc @feiskyer |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "RUN sed" command in the Dockerfile makes the building of Docker images for various archs error out with "standard_init_linux.go:190: exec user process caused "exec format error"". Hence I have got out the common /etc/nginx/conf.d/default.conf file and copied it into the image after a sed via Makefile.
Fixes #287
Signed-off-by: Nitesh Konkar [email protected]