Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make crictl and critest statically linked. #296

Merged
merged 1 commit into from
May 2, 2018

Conversation

Random-Liu
Copy link
Contributor

Make crictl and critest statically linked.

This makes is possible to use crictl inside container. (See kubernetes/kubernetes#63355)
This also makes the binary smaller.

Statically linked binary:

$ ls -alh $GOPATH/bin/crictl
-rwxr-x--- 1 lantaol primarygroup 26M May  2 02:11 /usr/local/google/home/lantaol/workspace/bin/crict

Dynamically linked binary:

$ ls -alh $GOPATH/bin/crictl
-rwxr-x--- 1 lantaol primarygroup 28M May  2 02:12 /usr/local/google/home/lantaol/workspace/bin/crictl

Signed-off-by: Lantao Liu [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2018
@Random-Liu Random-Liu added this to the v1.0.0-beta.1 milestone May 2, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 2, 2018
@feiskyer
Copy link
Member

feiskyer commented May 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2018
@Random-Liu Random-Liu merged commit 49847ed into kubernetes-sigs:master May 2, 2018
@Random-Liu Random-Liu deleted the statically-link branch May 2, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants