Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid panic when runtimes are using truncated IDs #268

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

feiskyer
Copy link
Member

@k8s-ci-robot
Copy link
Contributor

@feiskyer: GitHub didn't allow me to request PR reviews from the following users: adelton.

Note that only kubernetes-incubator members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fix #265.

/cc @adelton @mrunalp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from mrunalp March 15, 2018 02:58
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2018
@Random-Liu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2018
@Random-Liu Random-Liu merged commit b15605a into kubernetes-sigs:master Mar 15, 2018
@feiskyer feiskyer deleted the fix-trunc branch March 15, 2018 06:46
@adelton
Copy link
Contributor

adelton commented Mar 15, 2018

Thank you. Are the <none> <none> records without IMAGE ID expected?

# crictl images
IMAGE                               TAG                 IMAGE ID            SIZE
<none>                              <none>                                  0B
<none>                              <none>                                  0B
<none>                              <none>                                  0B
docker.io/kubernetes/pause          latest              f9d5de0795395       251kB
docker.io/library/busybox           latest              f6e427c148a76       1.36MB
registry.fedoraproject.org/fedora   27                  99b71991af6ee       246MB

Or is the fact that they don't have any IMAGE ID that bug in CRI-O which should be reported against it?

@feiskyer
Copy link
Member Author

Are the records without IMAGE ID expected?

I don't think so. @mrunalp Could you verify whether this is a cri-o bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants