critest: Add test for pid namespace #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@mrunalp PTAL |
mrunalp
reviewed
Mar 15, 2018
pkg/validate/security_context.go
Outdated
| By("get nginx container pid") | ||
| command := []string{"cat", "/proc/1/cmdline"} | ||
| output := execSyncContainer(rc, containerID, command) | ||
| Expect(string(output)).To(ContainSubstring("pause")) |
There was a problem hiding this comment.
pause depends upon what container is being used by the runtime. I guess doing a not of "master process" will be more portable across runtimes and different pod infra containers.
mrunalp
reviewed
Mar 15, 2018
pkg/validate/streaming.go
Outdated
| checkExec(rc, req, "hello\n", false) | ||
| }) | ||
|
|
||
| It("runtime should support exec with -it flags", func() { |
There was a problem hiding this comment.
You should make a different PR for exec tests. Also we should add a test for exec without -it in that PR.
There was a problem hiding this comment.
Removed the exec test, will open another PR with those tests.
Add test for pid namespace = container Add test for pid namespace = pod Signed-off-by: umohnani8 <[email protected]>
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
@feiskyer What is the difference between these 2 test cases? Shouldn't we test one container can/can't not access pid in another container? |
|
I see. One is contain, another is not contain. :) |
umohnani8
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for pid namespace = container
Add test for pid namespace = pod
Addresses issue #237
Signed-off-by: umohnani8 [email protected]