Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the label filter and fix a container list issue. #208

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

Random-Liu
Copy link
Contributor

This PR:

  1. Add parseLabelStringSlice util function.
  2. Fix an issue that filter is performed after json/yaml output in crictl ps. /cc @abhi

Signed-off-by: Lantao Liu [email protected]

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 30, 2017
@Random-Liu Random-Liu mentioned this pull request Nov 30, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2017
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feiskyer feiskyer merged commit a4d07f2 into kubernetes-sigs:master Nov 30, 2017
@abhi
Copy link
Contributor

abhi commented Nov 30, 2017

LGTM

@spiffxp spiffxp unassigned abhi Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants