cmd: crictl: add a config command #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Bump |
|
@runcom Thanks! This is really useful! |
Random-Liu
reviewed
Nov 16, 2017
cmd/crictl/config.go
Outdated
| configFile := context.GlobalString("config") | ||
| if _, err := os.Stat(configFile); err != nil { | ||
| // can't continue w/o config file | ||
| logrus.Fatalf("Falied to load config file: %v", err) |
There was a problem hiding this comment.
Can we create an empty config here instead?
cmd/crictl/config.go
Outdated
| // Get config from file. | ||
| config, err := ReadConfig(configFile) | ||
| if err != nil { | ||
| logrus.Fatalf("Falied to load config file: %v", err) |
There was a problem hiding this comment.
Can we return error instead? And same for the other log.
There was a problem hiding this comment.
Agreed. We can create the default config file /etc/crictl.yaml if it doesn't exist.
|
LGTM other than the comments. |
|
@runcom Thanks for adding this. |
Signed-off-by: Antonio Murdaca <[email protected]>
|
Comments addressed guys |
feiskyer
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly simple patch that just adds a
configcommand to get and set configurations similar togit config.This would be very needed for higher level commands like
kubeadmin order to gather stuff like theruntime-endpointto query.@feiskyer @Random-Liu PTAL
Signed-off-by: Antonio Murdaca [email protected]