Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attach and exec. #182

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Fix attach and exec. #182

merged 1 commit into from
Nov 7, 2017

Conversation

Random-Liu
Copy link
Contributor

@Random-Liu Random-Liu commented Nov 7, 2017 •
edited
Loading

New CRI fields Stdout and Stderr are not set.
And interactive is not used.

@feiskyer
Signed-off-by: Lantao Liu [email protected]

@Random-Liu
Fix attach and exec.
3cac43e 
Signed-off-by: Lantao Liu <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2017
feiskyer
feiskyer approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feiskyer feiskyer merged commit 65ea45b into kubernetes-sigs:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Random-Liu @feiskyer @k8s-ci-robot