Support mount propagation validation #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/L
|
@miaoyq Does cri-containerd pass this? |
|
@Random-Liu Yes, have passed. |
|
@miaoyq Cool! Will review it now. |
Random-Liu
reviewed
Sep 20, 2017
| rc.RemovePodSandbox(podID) | ||
| }) | ||
|
|
||
| It("mount with 'rprivate' should not support propagation", func() { |
There was a problem hiding this comment.
We should also check mount inside container could not be propagated to host.
| Expect(len(fileInfo)).NotTo(BeZero(), "len(fileInfo) should not be zero.") | ||
| }) | ||
|
|
||
| It("mount with 'rslave' should support propagation from host to container", func() { |
There was a problem hiding this comment.
We should also check mount inside container could not be propagated to host.
pkg/validate/container.go
Outdated
| Expect(len(output)).NotTo(BeZero(), "len(output) should not be zero.") | ||
| }) | ||
|
|
||
| It("mount without propagation option should not support propagation", func() { |
There was a problem hiding this comment.
This is not defined in CRI, runtime may return an error for non-supported mount propagation option, so let's not test this.
There was a problem hiding this comment.
OK, will remove this part.
Signed-off-by: Yanqiang Miao <[email protected]>
|
@Random-Liu Updated, cri-containerd have passed also. |
|
LGTM |
Random-Liu
added
the
lgtm
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #131.
/cc @feiskyer @Random-Liu
Signed-off-by: Yanqiang Miao [email protected]