Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for k8s 1.23 Pod Sandbox and New Stats #841

Closed
bobbypage opened this issue Nov 2, 2021 · 2 comments · Fixed by #886
Closed

Add support for k8s 1.23 Pod Sandbox and New Stats #841

bobbypage opened this issue Nov 2, 2021 · 2 comments · Fixed by #886
Assignees
@saschagrunert
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@bobbypage
Copy link

What would you like to be added:

K8s 1.23 added new CRI RPCs for pod sandbox and more detailed container stats. See kubernetes/enhancements#2371 for the k8s upstream issue.

kubernetes/kubernetes#102789 added the CRI fields namely PodSandboxStats, ListPodSandboxStats and some new fields for CPU and memory container stats.

crictl should be able to display the new Pod Sandbox Stats as well as the new cpu and memory container stats.

xref:
containerd/containerd#6112 / containerd/containerd#6113
kubernetes/kubernetes#102789

/cc @haircommander @qiutongs @mikebrow
@bobbypage bobbypage added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 2, 2021
@bobbypage bobbypage mentioned this issue Nov 2, 2021
Merged
@saschagrunert
Copy link
Member

Sounds great, are you happy to work on this @bobbypage?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2022
@saschagrunert saschagrunert added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 31, 2022
@saschagrunert saschagrunert self-assigned this Jan 31, 2022
@saschagrunert saschagrunert added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jan 31, 2022
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 2, 2022
@saschagrunert
Add crictl statsp command
5ab3cbc 
This new command can be used to retrieve the pod sandbox statistics in
the same way the `crictl stats` command exist.

Fixes kubernetes-sigs#841

Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 2, 2022
@saschagrunert
Add crictl statsp command
56d3164 
This new command can be used to retrieve the pod sandbox statistics in
the same way the `crictl stats` command exist.

Fixes kubernetes-sigs#841

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert saschagrunert mentioned this issue Feb 2, 2022
Merged
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 4, 2022
@saschagrunert
Add crictl statsp command
c6d3e52 
This new command can be used to retrieve the pod sandbox statistics in
the same way the `crictl stats` command exist.

Fixes kubernetes-sigs#841

Signed-off-by: Sascha Grunert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saschagrunert saschagrunert

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add crictl statsp command saschagrunert/cri-tools
4 participants
@bobbypage @saschagrunert @k8s-ci-robot @k8s-triage-robot