Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scaffold pkg and test project #93

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Remove scaffold pkg and test project #93

merged 1 commit into from
Oct 11, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Oct 10, 2018

No description provided.

@mengqiy mengqiy requested a review from droot October 10, 2018 22:57
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 10, 2018
@mengqiy mengqiy requested review from Liujingfang1 and removed request for DirectXMan12 and pwittrock October 11, 2018 02:19
@Liujingfang1
Copy link
Contributor

Is the plan to add this to kubebuilder?

@mengqiy
Copy link
Member Author

mengqiy commented Oct 11, 2018

Is the plan to add this to kubebuilder?

Yes. There will be a PR for that shortly

droot
droot reviewed Oct 11, 2018
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming its for the preparation to move it to kubebuilder repo. We should also delete generate_golden.sh also from here ?

I am assuming we will move all these changes to kubebuilder repo before merging this PR.

@mengqiy
Copy link
Member Author

mengqiy commented Oct 11, 2018

Right. It is deleted in https://github.com/kubernetes-sigs/controller-tools/pull/93/files#diff-59d90b4ae2a1649c75c68b352dcb3a49

@mengqiy
Copy link
Member Author

mengqiy commented Oct 11, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2018
@mengqiy mengqiy changed the title [WIP] remove scaffold pkg and test project Remove scaffold pkg and test project Oct 11, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Oct 11, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Oct 11, 2018

PTAL
kubernetes-sigs/kubebuilder#433 has been merged.

@droot droot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2018
@mengqiy mengqiy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6dce814 into kubernetes-sigs:master Oct 11, 2018
@mengqiy mengqiy deleted the mv_scaffold branch October 11, 2018 18:27
@matthchr matthchr mentioned this pull request Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot left review comments

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mengqiy @Liujingfang1 @k8s-ci-robot @droot