✨ Bump to k8s.io v1.24.0-rc.1 #666
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign @alvaroaleman |
|
/test pull-controller-tools-test-master |
sbueringer
force-pushed
the
pr-bump-v1.24-rc.01
branch
3 times, most recently
from
545c232 to
5b698c0
Compare
pkg/version/version.go
Outdated
| @@ -23,7 +23,7 @@ import ( | |||
| // Version returns the version of the main module | |||
| func Version() string { | |||
| info, ok := debug.ReadBuildInfo() | |||
| if !ok { | |||
| if !ok || (info != nil && info.Main.Version == "") { | |||
There was a problem hiding this comment.
A unit test failed without this change
It looks like previously ok was false. Now we get ok==true + an info object with an empty Version
There was a problem hiding this comment.
okay, interesting. That is IMHO a go bug as it breaks compatibility.
There was a problem hiding this comment.
Shouldn't it be
| if !ok || (info != nil && info.Main.Version == "") { | |
| if !ok || info == nil || info.Main.Version == "" { |
There was a problem hiding this comment.
Fixed
Maybe the func still behaves the same way but the tests are now built with module support ?!
There was a problem hiding this comment.
see #662 for explanation for this issue
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-bump-v1.24-rc.01
branch
from
5b698c0 to
633a769
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Stefan Büringer [email protected]