-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix SIGSERV when RawSpec is nil (due to anonymous struct) #1098
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: roelarents <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rkettelerij The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @rkettelerij. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@@ -404,7 +404,7 @@ func structToSchema(ctx *schemaContext, structType *ast.StructType) *apiext.JSON | |||
Properties: make(map[string]apiext.JSONSchemaProps), | |||
} | |||
|
|||
if ctx.info.RawSpec.Type != structType { | |||
if ctx.info.RawSpec != nil && ctx.info.RawSpec.Type != structType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this would allow embedded structs / anonymous structs, which does not seem to be allowed according to the error below?
Shouldn't this then be:
if ctx.info.RawSpec != nil && ctx.info.RawSpec.Type != structType { | |
if ctx.info.RawSpec == nil || ctx.info.RawSpec.Type != structType { |
This is the same PR as #892 but that one was automatically closed. This time testdata is included as requested so I'm hoping to get this merged.
From the original PR: