-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 pkg/crd: fix a missed type casting panic with new *types.Alias #1079
🐛 pkg/crd: fix a missed type casting panic with new *types.Alias #1079
Conversation
This is a follow up on 0a52475 ("pkg/crd: fix type casting panic with new default *types.Alias"). Look for the commit message of the cited commit for more context. Signed-off-by: Mahe Tardy <[email protected]>
@mtardy: GitHub didn't allow me to request PR reviews from the following users: markussiebert. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @mtardy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thank you! /ok-to-test |
/lgtm |
LGTM label has been added. Git tree hash: 1a973af38258da3257851f4ec7b6ff49827acb11
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtardy, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1076.
This is a follow up on 0a52475 ("pkg/crd: fix type casting panic with new default *types.Alias"). Look for the commit message of the cited commit for more context.
/cc @markussiebert @sbueringer