-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 add tests for simplified webhook interface #358
🏃 add tests for simplified webhook interface #358
Conversation
/assign @DirectXMan12 |
pkg/builder/build_test.go
Outdated
|
||
By("trying to register an existing mutating webhook path") | ||
path := generateMutatePath(schema.GroupVersionKind{Group: "foo.test.org", Version: "v1", Kind: "TestDefaulter"}) | ||
Ω(func() { svr.Register(path, nil) }).Should(Panic()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit of a weak test -- what if we add validation that handler is not nil, or something? Maybe we should check that it responds to a valid admission request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
PTAL
901b6f8
to
157eb42
Compare
157eb42
to
cd6fa1a
Compare
cd6fa1a
to
ad30658
Compare
/lgtm We'll need to resolve the dep management issue at some point, but this is fine for now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thirdparty tools to use k8s 1.11
Followup PR per #328 (comment)