-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Avoid dependency on apiserver/options if metrics/filters are used #2645
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
34349ce
to
1234273
Compare
Re: apidiff. My guess is apidiff might has problems with generics |
^^ @joelanford just fyi |
Signed-off-by: Stefan Büringer [email protected]
1234273
to
5172a23
Compare
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
Signed-off-by: Stefan Büringer [email protected]
This also avoids a dependency on component-base/metrics/prometheus/workqueue, which we really want to avoid as it initialized the workqueue metrics before our init.