⚠️ RESTMapper: don't treat non-existing GroupVersions as errors

[ary1992]

/kind bug

This PR fixes the new RESTMapper implementation to properly handle cases where an API Group / GroupVersion is not present in the system. Clients expect No{Kind,Resource}MatchErrors in this case.

The first commit increases the accuracy of the RESTMapper tests to verify the described expectations.
The second commit implements the actual fix.

The changes are from @timebertt PR #2425.
The PR #2425 is still needed as with non existing CRDs we are getting failed to find API group error.

[k8s-ci-robot]

Welcome @ary1992!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ary1992. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ary1992]

cc @alvaroaleman

[vincepri]

/hold

This is in direct contrast #2424

[ary1992]

This is in direct contrast #2424

WDYM ? We still need this fix right? refer #2425 (comment) . PR #2425 was closed saying it was fixed with #2472 but that is not the case. The issue is still there.

[alvaroaleman]

Wasn't this issue already fixed by #2472 ?

[ary1992]

Wasn't this issue already fixed by #2472 ?

I don't think so
#2425 (comment)

[akalenyu]

gentle ping 🙏 @alvaroaleman

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, ary1992

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vincepri]

/hold cancel

[sbueringer]

Hm are we okay with the cache filling up with invalid groups (that we didn't find) after this change?

I guess it only matters for memory usage as this data is not exposed if I see correctly.

[alvaroaleman]

Hm are we okay with the cache filling up with invalid groups (that we didn't find) after this change?

I guess the alternate is to handle absence of an entry in the map? Not sure if it will matter too much in practise as there isn't too much data in a group and this will only happen when requesting an absent group.