do not hold the lock after controller has started #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables controller to be able to create new watches after it has started. This is required for cases where you are writing some meta-controller which discovers new types to watch during the reconcilation.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
@DirectXMan12 did some analysis and found reconciliation workers are accessing thread-safe fields like |
|
I'll take a look when I'm a bit more coherent -- at a glance this looks ok, but I'd like to take a bit closer look |
shawn-hurley
approved these changes
Nov 2, 2018
|
/lgtm |
k8s-ci-robot
added
the
lgtm
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
…ter-start do not hold the lock after controller has started
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Update GitBook doc generation page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables controller to be able to create new watches after it has started.
This is required for cases where you are writing some meta-controller
which discovers new types to watch during the reconcilation.