🐛 envtest: fix CRD installation

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

Without this PR the CRD installation did not work:

• it panic'ed when .Conversion is nil
• it didn't add the Conversion config (because of copy in the array)
• we also have to add ConversionReviewVersions

Notes:

• in our case the base CRD files don't have conversion as they are added via patches: https://github.com/kubernetes-sigs/cluster-api/blob/master/config/crd/bases/cluster.x-k8s.io_clusters.yaml
• this didn't occur with v0.9 because there the conversion webhook was modified via unstructured. (this changed through this PR: b5eeb71#diff-b6b1b02e41870fbffb46bc5880965e53a92a1c6807bb3fae0e8473154fb416a4)

[sbueringer]

/assign @vincepri

[sbueringer]

/hold there is at least one other issue, I'll investigate

[vincepri]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/hold there is at least one other issue, I'll investigate

/hold cancel
already fixed it and updated the PR description accordingly (just forgot to remove the hold)