Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For downstream projects using go modules breaks due to uppercase 'github.com/Sirupsen/logrus' #219

Closed
paha opened this issue Nov 20, 2018 · 2 comments
Closed

For downstream projects using go modules breaks due to uppercase 'github.com/Sirupsen/logrus' #219

paha opened this issue Nov 20, 2018 · 2 comments

Comments

@paha
Copy link

paha commented Nov 20, 2018

For downstream projects using go modules fails due to uppercase reference at
https://github.com/kubernetes-sigs/controller-runtime/blob/master/Gopkg.lock#L72

Example output:

go: github.com/Sirupsen/[email protected]: parsing go.mod: unexpected module path "github.com/sirupsen/logrus"
go: error loading module requirements

re: golang/go#28489
re: golang/go#26208
@paha paha closed this as completed Nov 21, 2018
@siscia
Copy link

siscia commented Jan 24, 2019

@paha How was this solved?

@Setheck
Copy link

Setheck commented Mar 7, 2019

@siscia I was able to workaround with importing
github.com/Sirupsen/logrus v1.0.6
and adding the following exclusions to my go.mod

exclude github.com/Sirupsen/logrus v1.3.0
exclude github.com/Sirupsen/logrus v1.2.0
exclude github.com/Sirupsen/logrus v1.1.1
exclude github.com/Sirupsen/logrus v1.1.0

I'm guessing this is effectively rolling back to a version before the rename broke everything.

rodrigc pushed a commit to libopenstorage/openstorage that referenced this issue Mar 19, 2019
Add some exclusions to work around Sirupsen/logrus -> sirupsen/logrus
7f6dac4 
rename

See:
kubernetes-sigs/controller-runtime#219 (comment)

Signed-off-by: Craig Rodrigues <[email protected]>
rodrigc pushed a commit to libopenstorage/openstorage that referenced this issue Mar 19, 2019
Add some exclusions to work around Sirupsen/logrus -> sirupsen/logrus
6200e1a 
rename

See:
kubernetes-sigs/controller-runtime#219 (comment)

Signed-off-by: Craig Rodrigues <[email protected]>
rodrigc pushed a commit to libopenstorage/openstorage that referenced this issue Mar 28, 2019
Add some exclusions to work around Sirupsen/logrus -> sirupsen/logrus
27517a8 
rename

See:
kubernetes-sigs/controller-runtime#219 (comment)

Signed-off-by: Craig Rodrigues <[email protected]>
rodrigc pushed a commit to libopenstorage/openstorage that referenced this issue Mar 28, 2019
Add replacement rules for Sirupsen/logrus and docker/distribution
2e274de 
Recommended here:
golang/go#26904 (comment)
kubernetes-sigs/controller-runtime#219 (comment)

Signed-off-by: Craig Rodrigues <[email protected]>
rodrigc pushed a commit to libopenstorage/openstorage that referenced this issue Mar 28, 2019
Add replacement rules for Sirupsen/logrus and docker/distribution
1fc96ae 
Recommended here:
golang/go#26904 (comment)
kubernetes-sigs/controller-runtime#219 (comment)

Signed-off-by: Craig Rodrigues <[email protected]>
rodrigc pushed a commit to libopenstorage/openstorage that referenced this issue Apr 4, 2019
Add replacement rules for Sirupsen/logrus and docker/distribution
b93ab2a 
Recommended here:
golang/go#26904 (comment)
kubernetes-sigs/controller-runtime#219 (comment)

Signed-off-by: Craig Rodrigues <[email protected]>
rodrigc pushed a commit to libopenstorage/openstorage that referenced this issue Apr 15, 2019
Add replacement rules for Sirupsen/logrus and docker/distribution
2c72ad2 
Recommended here:
golang/go#26904 (comment)
kubernetes-sigs/controller-runtime#219 (comment)

Signed-off-by: Craig Rodrigues <[email protected]>
rodrigc pushed a commit to libopenstorage/openstorage that referenced this issue Sep 24, 2019
Add replacement rules
c491081 
Recommended here:
golang/go#26904 (comment)
kubernetes-sigs/controller-runtime#219 (comment)

Signed-off-by: Craig Rodrigues <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paha @Setheck @siscia