Create a multiarch image

[johngmyers]

This is an attempt to address #89.

I don't have gcloud credentials, so cannot test.

[k8s-ci-robot]

Welcome @johngmyers!

It looks like this is your first PR to kubernetes-sigs/cluster-proportional-autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-proportional-autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[hakman]

/assign @MrHohn

[MrHohn]

Sorry that I missed this. Thanks and I will try to test this and get back today.

[hakman]

Thanks @MrHohn !

[MrHohn]

Sorry for the delay, I tried to run this locally and hit the below error:

docker manifest create gcr.io/zihongz-k8s-dev/cluster-proportional-autoscaler:1.8.1-dirty --amend gcr.io/zihongz-k8s-dev/cluster-proportional-autoscaler-amd64:1.8.1-dirty --amend gcr.io/zihongz-k8s-dev/cluster-proportional-autoscaler-arm:1.8.1-dirty --amend gcr.io/zihongz-k8s-dev/cluster-proportional-autoscaler-arm64:1.8.1-dirty --amend gcr.io/zihongz-k8s-dev/cluster-proportional-autoscaler-ppc64le:1.8.1-dirty
docker manifest create is only supported on a Docker cli with experimental cli features enabled
make: *** [Makefile:109: multiarch-container] Error 1

Any prerequisite on the docker CLI configuration?

[MrHohn]

Okay, I was able to run it with "experimental": "enabled" set in docker config.

Looks like this is working fine - gcr.io/zihongz-k8s-dev/cluster-proportional-autoscaler:1.8.1-dirty for example.

[MrHohn]

Thanks!
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MrHohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

@MrHohn you could add DOCKER_CLI_EXPERIMENTAL=enabled in front of the new Docker commands or export it in the beginning of the Makefile.

DOCKER_CLI_EXPERIMENTAL=enabled docker manifest create $(MULTIARCH_IMAGE):$(VERSION) \
    $(addprefix --amend $(REGISTRY)/$(BIN)-, $(addsuffix :$(VERSION), $(ALL_ARCH)))

[johngmyers]

@MrHohn could we get a release cut with this PR in it?

[MrHohn]

@johngmyers Sorry for the delay - sure thing, let's track the release on #89.