-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Promote chrischdi to Cluster API maintainer #9997
🌱 Promote chrischdi to Cluster API maintainer #9997
Conversation
+10000000000000000 Thanks for everything you've been doing across the repo! It's getting hard to keep up 😅 |
LGTM label has been added. Git tree hash: 7fd49bddf6b8652851c6ebf99d80a9611c94d0e6
|
Thank you very much for all the work you're doing an Cluster API. It really is crucial to keep the project healthy !!!! Also +10000000000000000 from my side :) /lgtm |
Big +1! @chrischdi has been consistently doing a ton of great work in CAPI and CAPV for some time now, super well-deserved |
+1, thanks for all the hard work Christian |
+1 |
As mentioned in the office hours, 1 week lazy consensus |
+1 from my side as well, thank you for all your contributions so far!! /lgtm |
Thanks everyone for the help and support on this journey 🎉 👍 |
Nice, thanks @chrischdi! |
/approve |
As per office hours |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
593b88f
to
5536186
Compare
Rebased, #10042 hit the merge train faster 😂 |
/lgtm |
LGTM label has been added. Git tree hash: 10a3b2032d20910b1469888beb5be4f8cbac9c4b
|
What this PR does / why we need it:
This PR adds @chrischdi (that's me 😂 ) to cluster-api-maintainers.
I'm now working with the community and am contributing to the CAPI project for a good amount of time and also a reviewer for quite some time. I especially did work on ClusterClass features and on keeping the CI stable, deflaking issues, doing reviews, ... and want to continue with that in future.
I don't think we have the data quality to filter down for those specific areas so I'll just list all CAPI contributions:
/hold for consensus and community meeting
/cc @sbueringer
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area community-meeting