-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Bump to controller-runtime v0.17.0 & k8s.io v0.29 #9964
⚠️ Bump to controller-runtime v0.17.0 & k8s.io v0.29 #9964
Conversation
/test ? |
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-main /test pull-cluster-api-e2e-mink8s-main |
feec5f9
to
6db5131
Compare
/test pull-cluster-api-e2e-full-main /test pull-cluster-api-e2e-mink8s-main |
5a08f09
to
128c1c4
Compare
/test pull-cluster-api-e2e-full-main /test pull-cluster-api-e2e-mink8s-main |
128c1c4
to
71ada37
Compare
/test pull-cluster-api-e2e-full-main /test pull-cluster-api-e2e-mink8s-main |
71ada37
to
8cf0420
Compare
Signed-off-by: Stefan Büringer buringerst@vmware.com
Signed-off-by: Stefan Büringer buringerst@vmware.com
Some more adjustments as fake client is now setting GVK only for Unstructured. So I found a few more cases. Signed-off-by: Stefan Büringer buringerst@vmware.com
Signed-off-by: Stefan Büringer buringerst@vmware.com
Signed-off-by: Stefan Büringer buringerst@vmware.com
8cf0420
to
4c5fa85
Compare
/test pull-cluster-api-e2e-full-main /test pull-cluster-api-e2e-mink8s-main |
/assign @fabriziopandini @chrischdi Ready for review now |
Great work! What about adding a comment to the changes in API diff into the migration v16-->1.7 doc |
LGTM label has been added. Git tree hash: df0c6a6308410438418a84d9939d2f3003f388ab
|
lgtm |
No. We consider minor bumps of controller-runtime and Kubernetes libraries a breaking change, so we won't backport them. |
Makes sense, thanks |
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions / nits around klogr.New replacements. lgtm otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@sbueringer it seems that all the comments are addressed |
@fabriziopandini Yes we are! |
yay! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
I've split the PR intentionally in separate commits, to make the follow-up tasks after the bump clear and to make it easier to review.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #9578