Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add /agenda redirect in book #9961

Merged
merged 1 commit into from
Jan 10, 2024
Merged

📖 Add /agenda redirect in book #9961

merged 1 commit into from
Jan 10, 2024

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Jan 5, 2024

For this iteration, we'll keep using the 2023 agenda until the 2024 and the historical ones are available somewhere safe.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2024
@vincepri vincepri force-pushed the add-agenda-redirect branch from c11f567 to 8c9d9bc Compare January 5, 2024 18:02
@vincepri
Copy link
Member Author

vincepri commented Jan 5, 2024

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Jan 5, 2024
@vincepri
Copy link
Member Author

vincepri commented Jan 5, 2024

Confirmed this works in preview https://deploy-preview-9961--kubernetes-sigs-cluster-api.netlify.app/agenda

@vincepri
Copy link
Member Author

vincepri commented Jan 5, 2024

cc @CecileRobertMichon @richardcase we might want to collect providers' agendas this way as well?

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 79e9ca8fc6f91e3b5fb51fe72fb9697be8683cd8

chrischdi
chrischdi reviewed Jan 8, 2024
View reviewed changes
docs/book/book.toml Outdated Show resolved Hide resolved
@vincepri
📖 Add /agenda redirect in book
3a7768d 
For this iteration, we'll keep using the 2023 agenda until the 2024 and
the historical ones are available somewhere safe.

Signed-off-by: Vince Prignano <[email protected]>
@vincepri vincepri force-pushed the add-agenda-redirect branch from 8c9d9bc to 3a7768d Compare January 10, 2024 14:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4acf737157ed01d70b06df4cc394af4c07e9335f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@vincepri
Copy link
Member Author

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot
Copy link

@vincepri: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 46dcda2 into kubernetes-sigs:main Jan 10, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 10, 2024
@k8s-infra-cherrypick-robot
Copy link

@vincepri: new pull request created: #9979

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@ykakarap ykakarap Awaiting requested review from ykakarap

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@vincepri @sbueringer @k8s-ci-robot @fabriziopandini @k8s-infra-cherrypick-robot @chrischdi