🌱 feat: make docker machine bootstrap timeout configurable

[salasberryfin]

What this PR does / why we need it:

Currently, there is a 3 minute timeout for bootstrapping a Docker Machine. When not using CAPBK, it may take more than 3 minutes for bootstrap to succeed.

This PR adds a new optional field to DockerMachineSpec: BootstrapTimeout. When setting the timeout, it will default to 3 minutes if no value is set.

Which issue(s) this PR fixes:
Fixes #9530

/area provider/infrastructure-docker

[k8s-ci-robot]

Welcome @salasberryfin!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @salasberryfin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[salasberryfin]

/area provider/infrastructure-docker

[furkatgofurov7]

/ok-to-test

[richardcase]

As BootstrapTimeout is a new field you'll need to restore its value when going from v1alpha4 back to v1beta1 for the fuzzy tests to pass.

What this means is that for DockerMachine you'll need to make the ConvertTo/ConvertFrom functions in this similar to what is being done for DockerCluster....so store the marshalled version and then restore. I'll ping you on slack to chat.

[salasberryfin]

Thanks @richardcase. This is hopefully fixed now.

[salasberryfin]

@sbueringer thanks for the suggestions. Last push addresses both changes: setting type as *metav1.Duration and using a local variable.

[sbueringer]

Thank you!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e92f11793e388779439bdf6bf9443cc68d1c1b7e

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment