Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 remove deprecated code #9905

Closed
wants to merge 1 commit into from
+0 −6
Closed

🌱 remove deprecated code #9905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions cmd/clusterctl/client/cluster/cert_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,6 @@
waitCertManagerInterval = 1 * time.Second

certManagerNamespace = "cert-manager"

// This is maintained only for supporting upgrades from cluster created with clusterctl v1alpha3.
//
// Deprecated: Use clusterctlv1.CertManagerVersionAnnotation instead.
// TODO: Remove once upgrades from v1alpha3 are no longer supported.
certManagerVersionAnnotation = "certmanager.clusterctl.cluster.x-k8s.io/version"
)

var (
Expand Down Expand Up @@ -348,7 +342,7 @@
objVersion, ok := obj.GetAnnotations()[clusterctlv1.CertManagerVersionAnnotation]
if !ok {
// try the old annotation name
objVersion, ok = obj.GetAnnotations()[certManagerVersionAnnotation]

Check failure on line 345 in cmd/clusterctl/client/cluster/cert_manager.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: certManagerVersionAnnotation) (typecheck)

Check failure on line 345 in cmd/clusterctl/client/cluster/cert_manager.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: certManagerVersionAnnotation) (typecheck)

Check failure on line 345 in cmd/clusterctl/client/cluster/cert_manager.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: certManagerVersionAnnotation (typecheck)

Check failure on line 345 in cmd/clusterctl/client/cluster/cert_manager.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: certManagerVersionAnnotation) (typecheck)

Check failure on line 345 in cmd/clusterctl/client/cluster/cert_manager.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: certManagerVersionAnnotation) (typecheck)

Check failure on line 345 in cmd/clusterctl/client/cluster/cert_manager.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: certManagerVersionAnnotation) (typecheck)

Check failure on line 345 in cmd/clusterctl/client/cluster/cert_manager.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: certManagerVersionAnnotation (typecheck)

Check failure on line 345 in cmd/clusterctl/client/cluster/cert_manager.go

View workflow job for this annotation

GitHub Actions / lint 

undefined: certManagerVersionAnnotation) (typecheck)
if !ok {
currentVersion = "v0.11.0"
needUpgrade = true
Expand Down
Loading